Skip to content

Add a CI job running with a 32bits build of PHP #12366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Conversation

stof
Copy link
Contributor

@stof stof commented Apr 4, 2025

Refs #12365

@Seldaek
Copy link
Member

Seldaek commented Apr 4, 2025

I'm a little unsure if this is justified, that'll spend a lot of cpu cycles for a one-off issue with 32bit which is really quite rare these days..

@stof
Copy link
Contributor Author

stof commented Apr 4, 2025

Maybe this can be a separate workflow running in a cron (maybe once a week).

I think it still make sense to be able to discover issues with 32bits compat in composer before it reaches released versions, given how composer is a fundamental tool in the ecosystem.

@Seldaek
Copy link
Member

Seldaek commented Apr 4, 2025

Yeah, cron wouldn't have caught this though as I released too quick after merge.. So rather run this only on main, it'll limit the noise/cpu waste while still keeping the safeguard.

@stof
Copy link
Contributor Author

stof commented Apr 4, 2025

Idea: run it weekly and anytime the composer.lock changes. Also add the ability to trigger it manually from the github interface to allow on-demand runs if needed.

@Seldaek
Copy link
Member

Seldaek commented Apr 4, 2025

I think running on merge whenever something reaches main is ok, if we update dependencies that'll run it anyway..

@Seldaek Seldaek merged commit 17d7a3b into composer:main Apr 4, 2025
20 checks passed
@Seldaek
Copy link
Member

Seldaek commented Apr 4, 2025

Merging now to make sure it fails before I update json-schema

@stof stof deleted the patch-1 branch April 4, 2025 13:30
kayw-geek pushed a commit to kayw-geek/composer that referenced this pull request Aug 14, 2025
* Add a CI job running with a 32bits build of PHP

* Move to a run that only happens on main branch

---------

Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants