Skip to content

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Nov 17, 2024

Fixes #12201.

@phansys phansys marked this pull request as ready for review November 18, 2024 12:21
@Seldaek Seldaek added this to the 2.8 milestone Nov 25, 2024
@Seldaek Seldaek added the Bug label Nov 25, 2024
@Seldaek
Copy link
Member

Seldaek commented Nov 25, 2024

Yup thanks this is probably more sensible than returning the count.. One can count the advisories in the json output if they care about the count :)

@Seldaek Seldaek merged commit e468b73 into composer:main Nov 25, 2024
20 checks passed
@phansys
Copy link
Contributor Author

phansys commented Nov 25, 2024

Thank you!

Regarding the STATUS_ prefix in the constants, please, be aware that I decided not to use the "status" term in order to avoid confusions, as these values are not always what the user receives.
My reasoning was that they are the basis of the final result, but not an exact representation of it.

@phansys phansys deleted the audit_exit_code branch November 25, 2024 13:59
@Seldaek
Copy link
Member

Seldaek commented Nov 25, 2024

Yeah fair enough but BIT_ sounds like leaking an implementation detail in the name to me.. I guess both have some flaws :D But I don't really expect many will rely on these constants as this is usually called via CLI, so no biggie either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit command should produce deterministic exit codes
2 participants