-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Better app password support for bitbucket #12103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better app password support for bitbucket #12103
Conversation
…et repositories stored with ssh
Co-authored-by: Christophe Coevoet <stof@notk.org>
Updated PR, I see there is a failing phpstan run on PHP 8.3 but seems unrelated to this PR |
Thanks, I just hope this won't cause regressions for some edge cases. |
I hope so too 😬 At least now we have the test coverage in place and it would be much more trivial to refactor and add more tests |
Hey there. Just wanted to say I saw the message and I hope I will be able to. Just has not been possible yet 😅 |
No worries, it's fixed by #12462 |
This fixes #12102
It also fixes what is kind of a bad UX if you have stored actual credentials for bitbucket (for example an app password) and composer will then try to first request an access token for you using them, and in the process show some errors:
There are actually colors and everything. Looks super scary and wrong. And 2 times even. But it's actually just warnings, and the code path that works, is executed later. Attached also an image of this scary warning
So yeah this PR fixes both of those issues. I only created an actual issue for the first of them. I could go ahead and create one for the other one if appropriate and needed for bookkeeping?