-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix misleading configuration option name in error message #12498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kayw-geek
wants to merge
99
commits into
composer:main
from
kayw-geek:bugfix/fix-exclude-from-classmap-link-text
Closed
Fix misleading configuration option name in error message #12498
kayw-geek
wants to merge
99
commits into
composer:main
from
kayw-geek:bugfix/fix-exclude-from-classmap-link-text
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agnose command, refs composer#12196
…rading to warning, fixes composer#12196
… fix If the installer script linked from [this page]([https://getcomposer.org/doc/faqs/how-to-install-composer-programmatically.md](https://getcomposer.org/doc/faqs/how-to-install-composer-programmatically.md)) is run using PHP 8, it generates the following deprecation notice. ``` Deprecated: Function openssl_free_key() is deprecated since 8.0, as OpenSSLAsymmetricKey objects are freed automatically in Standard input code on line 982 ``` This issue was [fixed in the installer script]([composer/getcomposer.org#159](composer/getcomposer.org#159)), but the documentation was not updated to link to the version of it that includes the fix.
This will simplify secure installation of composer in GitHub Actions to two calls to `gh` cli with no need to manually import any PGP signing keys: gh release --repo composer/composer download --pattern composer.phar gh attestation verify --repo composer/composer composer.phar Given that the current PGP signing key is stored as a GitHub Action secret, this type of attestation is no less secure than the existing PGP signing.
Glad that I added some tests as this meant I found a bug in the PR I pulled previously (composer#12257). The `thanks_dev` key expects a username in the format `u/gh/USERNAME`, but the call to `basename()` was stripping the `u/gh/` part off. If the use of `basename()` is preferred here, the alternative would be to add `u/gh/` to the default URL prefix for thanks.dev. Let me know if you me to change that.
…ing output too much with deprecation notices (composer#12360)
* Add a CI job running with a 32bits build of PHP * Move to a run that only happens on main branch --------- Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
composer#12383) * Do not output script being run when running via composer <script-name> Fixes composer#12375 * Fix global test expectations
composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current error message displays incorrect configuration option name when terminal doesn't support hyperlinks:
The hyperlink anchor text
exclude-files-from-classmap
is actually pointing to the documentation section#exclude-files-from-classmaps
, but the actual configuration option documented there isexclude-from-classmap
.Impact
When users' terminals don't support hyperlinks, they see
exclude-files-from-classmap
as plain text and mistakenly believe this is the correct configuration option. This leads to invalid composer.json configurations that don't work.Solution
Update the error message to show the correct configuration option name
exclude-from-classmap
instead of using the documentation anchor as the link text.Before
After
This ensures users see the correct configuration option name regardless of their terminal's hyperlink support.