Skip to content

diagnose: correctly show curl features #12485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

diagnose: correctly show curl features #12485

merged 1 commit into from
Aug 20, 2025

Conversation

tbvdm
Copy link
Contributor

@tbvdm tbvdm commented Jul 23, 2025

If curl has no brotli support, composer diagnose should print missing for brotli, but instead it prints nothing:

curl version: 8.14.1 libz 1.3.1.1-motley brotli  zstd missing ssl LibreSSL/4.1.0

In the array returned by curl_version(), the brotli_version array element is set to to the empty string if brotli support is missing, not to null. The same goes for libz_version and ssl_version.

@tbvdm tbvdm force-pushed the correctly-show-curl-features branch 2 times, most recently from 3ae8997 to 4042e18 Compare July 23, 2025 18:37
@tbvdm tbvdm force-pushed the correctly-show-curl-features branch from 4042e18 to 68ae5ac Compare July 23, 2025 19:01
@Seldaek Seldaek merged commit fb05250 into composer:2.8 Aug 20, 2025
20 checks passed
@Seldaek
Copy link
Member

Seldaek commented Aug 20, 2025

Thanks! I didn't have a system without support available so didn't notice :)

@Seldaek Seldaek added this to the 2.8 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@tbvdm @Seldaek