Fix notification callback not being valid/reachable #12472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jul 10, 2025
| */ | ||
| protected function callbackGet(int $notificationCode, int $severity, ?string $message, int $messageCode, int $bytesTransferred, int $bytesMax) | ||
| public function callbackGet(int $notificationCode, int $severity, ?string $message, int $messageCode, int $bytesTransferred, int $bytesMax) |
There was a problem hiding this comment.
you could use Closure::fromCallable instead, which exists since PHP 7.1
There was a problem hiding this comment.
Good point, forgot about that one. Updated
|
Would it make sense to add a test to safeguard against regressions for the issue described in #12471 ? Edit: then again, there may already be a test in place, but looks like the tests are not run against PHP 8.5 yet. |
|
Skipping tests because the RemoteFilesystem class is really some last resort fallback thing that nobody should use in theory, and I cannot be bothered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12471