Fix Bitbucket oauth failure #12462
Merged
Fix Bitbucket oauth failure #12462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change match index from 1 to 2 to account for recently changed regex expressions for Bitbucket URLs
stof
approved these changes
Jun 27, 2025
|
Makes sense, thanks for digging into it! |
|
Thanks @Seldaek , will this make its way into main as well, or is that another pull request. Just asking as this will be in all future versions. |
|
Yes for sure, I'll merge up to main later, and try to get a 2.8 patch release out this week some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change match index from 1 to 2 to account for recently changed regex expressions for Bitbucket URLs
Based on changes from PR #12103. Bitbucket URL regex was changed, but following reference to $match for $bitbucketUtil->authorizeOAuthInteractively were not updated accordingly.