Skip to content

Fix creation of empty archives #12408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Fix creation of empty archives #12408

merged 2 commits into from
May 13, 2025

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented May 12, 2025

Fixes #12391

cc @glaubinix

@Seldaek Seldaek added this to the 2.8 milestone May 12, 2025
@glaubinix
Copy link
Contributor

glaubinix commented May 13, 2025

@Seldaek the tar file that you create somehow looks off.

The generated tar file with the composer archive wpackagist-plugin/individual-multisite-author 1.0 -vvv command from the issue cannot be opened.

Opening it with new \PharData($file) throws Uncaught UnexpectedValueException: Cannot create phar 'wpackagist-plugin-individual-multisite-author-1.0-a42e54.tar', file extension (or combination) not recognised or the directory does not exist. Extracting it with tar seems to work

tar -xvf  wpackagist-plugin-individual-multisite-author-1.0-a42e54.tar
tar: A lone zero block at 1

@Seldaek
Copy link
Member Author

Seldaek commented May 13, 2025

Ok can you try with the latest commit?

@glaubinix
Copy link
Contributor

Works! No warnings/notices anymore with the tar command too!

@Seldaek
Copy link
Member Author

Seldaek commented May 13, 2025

Ok great 👍🏻

@Seldaek Seldaek merged commit 9877bf6 into composer:main May 13, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer archive for an empty svn tag triggers ErrorException
2 participants