Add driver_opts to services.networks #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmry
commented
May 14, 2024
71f2537 to
825e27c
Compare
Signed-off-by: Rob Murray <rob.murray@docker.com>
825e27c to
53ba01b
Compare
ndeloof
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It's possible to set driver options when creating a network using compose ... compose spec / engine API.
But not when connecting an endpoint to a network ... compose spec / engine API.
The API field isn't new, but upcoming change moby/moby#47686 means it'll be useful for setting per-interface sysctls.
compose-spec/compose-go#627 adds the types, this updates the spec to match.
(
composewill need an update to pass driver-opts into the engine API'sEndpointSettings.)Which issue(s) this PR fixes:
n/a