Skip to content

Fix broken interpolation with JSON (curly braces) default values #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2024
Merged

Fix broken interpolation with JSON (curly braces) default values #581

merged 1 commit into from
Feb 18, 2024

Conversation

shcheklein
Copy link
Contributor

Hopefully should be enough to fix a downstream docker compose issue:

   environment:
      PARSING_LIMITS: ${PARSING_LIMITS:-{"commits":1}}

Now it returns:

$ export PARSING_LIMITS='{"commits":2}'
$ docker-compose -f docker-compose.yaml config | grep PARSING
PARSING_LIMITS: '{"commits":2}}'

Mind an extra } at the end of the value.

It prevents from using JSON string as a default value for an environment variable.

@shcheklein shcheklein requested a review from ndeloof as a code owner February 18, 2024 00:26
@shcheklein shcheklein force-pushed the fix-default-curly-braces-interpolation branch from 5f0dfa6 to 5182e84 Compare February 18, 2024 00:27
@shcheklein
fix(interpolation): default values can contain curly braces
fea6c32 
Signed-off-by: Ivan Shcheklein <shcheklein@gmail.com>
@shcheklein shcheklein force-pushed the fix-default-curly-braces-interpolation branch from 5182e84 to fea6c32 Compare February 18, 2024 00:27
@ndeloof ndeloof merged commit 5ede864 into compose-spec:main Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shcheklein @ndeloof