Skip to content

loader: fix a panic #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

loader: fix a panic #472

merged 1 commit into from
Oct 17, 2023

Conversation

nicks
Copy link
Contributor

@nicks nicks commented Oct 13, 2023

fixes #471

@nicks nicks requested a review from ndeloof as a code owner October 13, 2023 21:58
@nicks
Copy link
Contributor Author

nicks commented Oct 13, 2023

(originally was going to only file the issue, but it turned out to be easy enough to fix)

@nicks
loader: fix a panic
162cc09 
fixes compose-spec#471

Signed-off-by: Nick Santos <nick.santos@docker.com>
ndeloof
ndeloof approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I really miss constructors in go so that we can have default values and empty maps set vs nil

@ndeloof ndeloof merged commit f56910a into compose-spec:master Oct 17, 2023
@nicks nicks deleted the nicks/panic branch October 17, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

@glours glours glours approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loader panic
3 participants
@nicks @ndeloof @glours