loader: path resolution consistency #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the project working directory absolute path resolution to `ResolveRelativePaths` and remove redundant local volume (a rarely used way of creating bind mounts) absolute path resolution from the normalization method. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
commented
Jun 28, 2023
Comment on lines
-131
to
-143
| for name, config := range project.Volumes { | ||
| if config.Driver == "local" && config.DriverOpts["o"] == "bind" { | ||
| // This is actually a bind mount | ||
| config.DriverOpts["device"] = absPath(project.WorkingDir, config.DriverOpts["device"]) | ||
| project.Volumes[name] = config | ||
| } | ||
| } |
There was a problem hiding this comment.
This logic was duplicated in ResolveRelativePaths:
Lines 54 to 60 in 169d13b
N.B. It's actually SLIGHTLY different because the version in ResolveRelativePaths uses resolveMaybeUnixPath, which is arguably more correct.
ndeloof
approved these changes
Jul 6, 2023
glours
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the project working directory absolute path resolution to
ResolveRelativePathsand remove redundant local volume (a rarely used way of creating bind mounts) absolute path resolution from the normalization method.