loader: fix overly aggressive project name validation #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were cases where the loader would infer a perfectly valid project name by normalizing a directory, but would then re-validate the un-normalized project directory and throw an error. This moves all the validation into a single spot during the load, which is the only point that it has all the context. Some of this logic needs to be pushed out of here: it should NOT be reading the config files, for example. For now, this resolves the main issues. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
e0f8f12 to
057c586
Compare
ndeloof
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases where the loader would infer a perfectly valid project name by normalizing a directory, but would then re-validate the un-normalized project directory and throw an error.
This moves all the validation into a single spot during the load, which is the only point that it has all the context.
Some of this logic needs to be pushed out of here: it should NOT be reading the config files, for example.
For now, this resolves the main issues.