Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: compose-spec/compose-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.0
Choose a base ref
...
head repository: compose-spec/compose-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.0
Choose a head ref
  • 9 commits
  • 10 files changed
  • 5 contributors

Commits on Aug 31, 2022

  1. Fix required env vars ignored except the last one

    During the variable substitution, if a missing variable was followed
    by an existing one, the empty "outerErr" variable overwrote the previous
    non-empty variable.
    
    Unlike with Docker Compose v1, the first found error did not guarantee
    that an actual error would be thrown.
    
    Example which would have run before the fix even though var1 is not defined:
    
    ```yaml
    services:
      bash:
        image: bash:5.0.18-alpine3.15
        environment:
          var12: "_ ${var1:?Error1} _ ${var2:?Error2} _ "
        command:
          - env
    ```
    
    ```bash
    ```
    
    This change also means that, if multiple variables are missing in one string, the first one will be reported by Docker Compose
    
    Signed-off-by: Ákos Takács <takacs.akos@it-sziget.hu>
    rimelek committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8ce8973 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. dotenv: fix parse error on files with UTF-8 BOM

    Some Windows editors tend to add UTF-8 BOM markers to files,
    which breaks parsing of `.env` files.
    
    Now, when the file is read, if it starts with a UTF-8 BOM,
    we'll skip it. (`.env` files are always processed as UTF-8.)
    
    See docker/compose#9799.
    
    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    milas committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f4d0f7d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Bump github.com/docker/go-units from 0.4.0 to 0.5.0

    Bumps [github.com/docker/go-units](https://github.com/docker/go-units) from 0.4.0 to 0.5.0.
    - [Release notes](https://github.com/docker/go-units/releases)
    - [Commits](docker/go-units@v0.4.0...v0.5.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/docker/go-units
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    9b6a376 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #303 from compose-spec/dependabot/go_modules/githu…

    …b.com/docker/go-units-0.5.0
    
    Bump github.com/docker/go-units from 0.4.0 to 0.5.0
    glours authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4eed03f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge pull request #301 from milas/env-file-utf8-bom

    dotenv: fix parse error on files with UTF-8 BOM
    glours authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    34d8f70 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge pull request #242 from rimelek/fix-required-envvars-ignored-exc…

    …ept-last
    
    Fix required env vars ignored except the last one
    ulyssessouza authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ccdcc95 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. env: fix errors on valid interpolation expressions (#307)

    The parser was too strict here and would reject valid constructs
    that used an unescaped `$` that was not part of a variable
    expression (and not ambiguous).
    
    Now, only errors for unmatched braced expressions (e.g. `${FOO`)
    are returned, but other valid cases are ignored and the `$` will
    be treated literally, e.g. `a $ string` -> `a $ string`, which is
    the same as in POSIX.
    
    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    milas authored Sep 23, 2022
    Configuration menu
    Copy the full SHA
    6bf774c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. ci: use currently maintained Golang releases (1.18 & 1.19) (#309)

    Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
    glours authored Sep 26, 2022
    Configuration menu
    Copy the full SHA
    be0dada View commit details
    Browse the repository at this point in the history
  2. env: fix a bunch of escaping/parsing edge cases (#308)

    * Handle standard escape sequences based on XSI/XBD
      https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html
    * Fix parsing with escaped quotes at end of quoted
      value
    * Handle key whose name starts with `export` (require
      whitespace between `export` keyword when stripping)
    * Fix parsing of unquoted values with embedded `#`
      (require a space before starting an inline comment)
    * Use correct parser methods throughout all test cases
    * Eliminate a lot of unused code that was not working
      right
    
    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    milas authored Sep 26, 2022
    Configuration menu
    Copy the full SHA
    08a21df View commit details
    Browse the repository at this point in the history
Loading