Preserve hidden metadata values when reading from GUI form #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordwelch
requested changes
Oct 4, 2024
comictaggerlib/taggerwindow.py
Outdated
| @@ -940,6 +940,9 @@ def form_to_metadata(self) -> None: | |||
| md.add_credit(name, role, bool(primary_flag)) | |||
|
|
|||
| md.pages = self.page_list_editor.get_page_list() | |||
|
|
|||
| # Preserve hidden md values | |||
| md.overlay(self.metadata, mode=comicapi.merge.Mode.ADD_MISSING, merge_lists=False) | |||
There was a problem hiding this comment.
This doesn't account for when someone wants to remove something, how would I remove the title from a comic that already has one set
|
I knew there was a reason why I rejected that way initially... I've left it in the As the tag plugins now (I believe all?) receive the initial read data, it might be better to add |
lordwelch
requested changes
Oct 12, 2024
b2c5511 to
170476a
Compare
lordwelch
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
write_tagsis used,form_to_metadatais called within it which means any "hidden" values such asdata-origin,identifier,price,rights,issue_id,series_id,is_version_ofandlast_markare erased.Some of these values are/may be of use to a tag plugin. (Saving the
issue_isandseries_idin ACBF for example.)I'm not sure if doing it in the
form_to_metadatawill cause problems anywhere else? The other option I considered was to pull the values out in thewrite_tagsmethod and then place them back afterform_to_metadata.