-
Notifications
You must be signed in to change notification settings - Fork 81
Use custom delegate to unify combobox item style #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A combined delegate for read and modify could be worked out (signals etc.) but for ease right now. |
So it's an extra tick but is the tick also a bit larger too? I was wondering if PyQt6 is going to make any difference to this at all but I don't think it will. IIRC the problem was only on Linux (I'll check), so I think it's possible to do this change only for Linux. |
0ca56b8
to
66cfceb
Compare
Try this. It looks like the "tick" was being drawn twice (didn't notice because it was perfectly aligned) so I've removed the draw from the code here. |
Now I don't get any visible check on MacOS and It crashed when I clicked on the 'Write Tags' checkbox too much
|
Try this. If not then skipping it on MacOS might be the option. I did wonder about the purpose of Not too sure on the |
By default on MacOS it only has a tick. There is no checkbox |
In the double tick screenshot you gave above; is the box there not usually there? Does this just draw a box and the tick or just the box? Any harm in having the boxes? If there's still a problem: Because I can't try different solution, if I put in some different options commented out so you can try them, is that okay? |
Sure |
It looks like you can reset to a44e037 and then you just need to remove the extra import platform |
99e7ac0
to
8ace830
Compare
I've reset and removed the double import. Is that original one now working (with the PyQt5 5.15.11 update)? If not, I'll push the other options. |
It works on MacOS now |
On Linux (tested) changes:


Which are oversized checkboxes to: