Skip to content

Support multiple web_links #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 9, 2024
Merged

Conversation

lordwelch
Copy link
Member

No description provided.

@lordwelch lordwelch requested a review from mizaki February 17, 2024 23:12
@lordwelch
Copy link
Member Author

It still needs a better control than a single line edit.
This is implemented to include more compatibility with ComicRack see anansi-project/comicinfo#56

Ensure the j specifier in MetadataFormatter converts to str before joining
Add a web_link variable to the filerenamer
@mizaki
Copy link
Contributor

mizaki commented Feb 18, 2024

The web link in the GUI remains red.
comictagger.py:115

"web_link": self.leWebLink,

web_link should be web_links

@mizaki
Copy link
Contributor

mizaki commented Feb 18, 2024

The web link button doesn't work correctly, send the whole line with both URLs to browser.

Could change the web link line edit to a combo box and then clicking the visit button goes to whatever's picked but it could be confusing. Users might think it's the URL they want to save.

A multiline edit with the URLs themselves as normal links, ideally it would expand vertically for each line. This is the best bad idea, I think.

Fix web_link in md_attributes
@mizaki
Copy link
Contributor

mizaki commented Feb 25, 2024

This is what I see when I go to the Notes tab:
image
There is no highlighted line (it makes sense it's is the top line though), maybe helpful to highlight the top line.

Similar when adding a line:
ct_weblinks
Here CT could add https:// and set the line as editing after the add button is pressed.

With other themes all this may be more obvious?

@lordwelch lordwelch closed this Feb 27, 2024
@lordwelch lordwelch deleted the web-links branch February 27, 2024 03:14
@lordwelch lordwelch restored the web-links branch February 27, 2024 03:18
@lordwelch lordwelch reopened this Feb 27, 2024
@mizaki
Copy link
Contributor

mizaki commented Feb 29, 2024

Is it just me? I can no longer edit the fields and the text is "greyed out"? I don't seem to be able to interact with it at all, even the scroll bar doesn't work.
web_links2

@lordwelch
Copy link
Member Author

Are you editing comicrack metadata?

@mizaki
Copy link
Contributor

mizaki commented Feb 29, 2024

Are you editing comicrack metadata?

Ah, it was Comic Info XML which I thought would be the same as Comic Rack.

It does show that (stupid) people might need the buttons disabled too.

Other than that, it looks good.

@lordwelch
Copy link
Member Author

Yeah cix doesn't have the attribute name updated yet because it's in a different repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants