-
Notifications
You must be signed in to change notification settings - Fork 81
Support multiple web_links #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It still needs a better control than a single line edit. |
Ensure the j specifier in MetadataFormatter converts to str before joining Add a web_link variable to the filerenamer
The web link in the GUI remains red. "web_link": self.leWebLink,
|
The web link button doesn't work correctly, send the whole line with both URLs to browser. Could change the web link line edit to a combo box and then clicking the visit button goes to whatever's picked but it could be confusing. Users might think it's the URL they want to save. A multiline edit with the URLs themselves as normal links, ideally it would expand vertically for each line. This is the best bad idea, I think. |
Fix web_link in md_attributes
Are you editing comicrack metadata? |
Ah, it was Comic Info XML which I thought would be the same as Comic Rack. It does show that (stupid) people might need the buttons disabled too. Other than that, it looks good. |
Yeah cix doesn't have the attribute name updated yet because it's in a different repo |
No description provided.