Deduplicate and move configuration vars in a single place between Makefile and experiment.mk #34
Conversation
Move the variables that are important for the Terraform configuration back to the Makefile. Deduplicate variable assignments in experiment.mk that are also present in Makefile. You gotta make up your mind on the single place where these need to be defined, and I don't think the experiment parameters are it.
Makefile
Outdated
| DO_INSTANCE_TAGNAME=main-testnet | ||
| DO_VPC_SUBNET=172.19.144.0/20 |
There was a problem hiding this comment.
The idea behind moving these two variables together is that it's necessary to customize them both to deconflict QA testnet experiments running concurrently in the same project. If experiment.mk looks like a more appropriate place for this, let's move them both there.
|
I am good with the deduplication and agree that DO_VPC_SUBNET and DO_INSTANCE_TAGNAME should be together (it was my omission), but I think experiment.mk is the place to have, since DO_VPC_SUBNET is a also an experiment wide configuration. |
Same user might be running multiple experiments, and the intent is to concentrate per-experiment customization to experiment.mk to leave Makefile unchanged.
I've done as suggested, thanks. I'm not sure if |
|
Good point. Probably. But we can move them there once we start doing multi-version tests. |
Move the variables that are important for the Terraform configuration back to the
Makefile. Deduplicate variable assignments inexperiment.mkthat are also present inMakefile. It's better to have the single place where these need to be defined, and I don't think the experiment parameters file is it.