chore: bump Go MSRV to 1.22 and grocksdb version #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
faddat
commented
Apr 4, 2024
- build(deps): bump github.com/linxGnu/grocksdb from 1.8.12 to 1.8.14
- update rocksdb in the dockerfile that the tests run in
Bumps [github.com/linxGnu/grocksdb](https://github.com/linxGnu/grocksdb) from 1.8.12 to 1.8.14. - [Release notes](https://github.com/linxGnu/grocksdb/releases) - [Commits](linxGnu/grocksdb@v1.8.12...v1.8.14) --- updated-dependencies: - dependency-name: github.com/linxGnu/grocksdb dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 76.80% 78.12% +1.31%
==========================================
Files 23 23
Lines 2048 1714 -334
==========================================
- Hits 1573 1339 -234
+ Misses 403 298 -105
- Partials 72 77 +5 |
4 tasks
adizere
reviewed
Apr 5, 2024
| @@ -18,7 +18,7 @@ RUN apt update \ | |||
| libleveldb-dev libleveldb1d | |||
|
|
|||
| FROM build AS install | |||
| ARG ROCKSDB=8.9.1 | |||
| ARG ROCKSDB=8.11.3 | |||
There was a problem hiding this comment.
looks good cf. https://github.com/linxGnu/grocksdb/releases/tag/v1.8.14
|
The release that we use has to match the release in grocksdb, so we would want to use 13 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.