Skip to content

Add Vote Extension varying size testnet (backport #888) #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2023
Merged

Add Vote Extension varying size testnet (backport #888) #906

merged 2 commits into from
Jun 2, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 2, 2023

This is an automatic backport of pull request #888 done by Mergify.
Cherry-pick of 028fb5e has failed:

On branch mergify/bp/v0.38.x/pr-888
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit 028fb5eb0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/qa/CometBFT-QA-38.md
	new file:   docs/qa/img38/voteExtensions/02k_1_block_rate.png
	new file:   docs/qa/img38/voteExtensions/02k_1_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/02k_avg_cpu.png
	new file:   docs/qa/img38/voteExtensions/02k_avg_memory.png
	new file:   docs/qa/img38/voteExtensions/02k_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/02k_block_rate.png
	new file:   docs/qa/img38/voteExtensions/02k_rounds.png
	new file:   docs/qa/img38/voteExtensions/02k_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/04k_1_block_rate.png
	new file:   docs/qa/img38/voteExtensions/04k_1_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/04k_avg_cpu.png
	new file:   docs/qa/img38/voteExtensions/04k_avg_memory.png
	new file:   docs/qa/img38/voteExtensions/04k_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/04k_block_rate.png
	new file:   docs/qa/img38/voteExtensions/04k_rounds.png
	new file:   docs/qa/img38/voteExtensions/04k_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/08k_1_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/08k_1_block_rate.png
	new file:   docs/qa/img38/voteExtensions/08k_1_rounds.png
	new file:   docs/qa/img38/voteExtensions/08k_1_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/08k_avg_cpu.png
	new file:   docs/qa/img38/voteExtensions/08k_avg_memory.png
	new file:   docs/qa/img38/voteExtensions/08k_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/08k_rounds.png
	new file:   docs/qa/img38/voteExtensions/08k_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/16k_1_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/16k_1_block_rate.png
	new file:   docs/qa/img38/voteExtensions/16k_1_rounds.png
	new file:   docs/qa/img38/voteExtensions/16k_1_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/16k_avg_cpu.png
	new file:   docs/qa/img38/voteExtensions/16k_avg_memory.png
	new file:   docs/qa/img38/voteExtensions/16k_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/16k_block_rate.png
	new file:   docs/qa/img38/voteExtensions/16k_rounds.png
	new file:   docs/qa/img38/voteExtensions/16k_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/32k_1_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/32k_1_block_rate.png
	new file:   docs/qa/img38/voteExtensions/32k_1_rounds.png
	new file:   docs/qa/img38/voteExtensions/32k_1_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/32k_avg_cpu.png
	new file:   docs/qa/img38/voteExtensions/32k_avg_memory.png
	new file:   docs/qa/img38/voteExtensions/32k_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/32k_block_rate.png
	new file:   docs/qa/img38/voteExtensions/32k_rounds.png
	new file:   docs/qa/img38/voteExtensions/32k_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/8k_block_rate.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_16k.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_2k.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_32k.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_4k.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_64k.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_8k.png
	new file:   docs/qa/img38/voteExtensions/all_c1r400_baseline.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_16k.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_2k.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_32k.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_4k.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_64k.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_8k.png
	new file:   docs/qa/img38/voteExtensions/all_experiments_baseline.png
	new file:   docs/qa/img38/voteExtensions/baseline_1_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/baseline_1_block_rate.png
	new file:   docs/qa/img38/voteExtensions/baseline_1_rounds.png
	new file:   docs/qa/img38/voteExtensions/baseline_1_total_txs_rate.png
	new file:   docs/qa/img38/voteExtensions/baseline_avg_cpu.png
	new file:   docs/qa/img38/voteExtensions/baseline_avg_memory.png
	new file:   docs/qa/img38/voteExtensions/baseline_avg_mempool_size.png
	new file:   docs/qa/img38/voteExtensions/baseline_block_rate.png
	new file:   docs/qa/img38/voteExtensions/baseline_rounds.png
	new file:   docs/qa/img38/voteExtensions/baseline_total_txs_rate.png
	modified:   docs/qa/method.md
	modified:   scripts/qa/reporting/latency_plotter.py
	modified:   scripts/qa/reporting/prometheus_plotter.py
	modified:   scripts/qa/reporting/requirements.txt

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   RELEASES.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@lasarojc @mergify
Add Vote Extension varying size testnet (#888)
a629dbf 
This PR modifies the e2e app to allow varying the size of vote extensions to test the effect of VE on the system performance.
Results of tests executed are also reported here.
This work is being done as part of the v0.38.0 QA.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit 028fb5e)

# Conflicts:
#	RELEASES.md
@mergify mergify bot requested a review from a team as a code owner June 2, 2023 11:35
@mergify mergify bot added the conflicts label Jun 2, 2023
lasarojc
lasarojc reviewed Jun 2, 2023
View reviewed changes
lasarojc
lasarojc reviewed Jun 2, 2023
View reviewed changes
@lasarojc lasarojc removed the conflicts label Jun 2, 2023
@lasarojc lasarojc self-assigned this Jun 2, 2023
@lasarojc lasarojc added the qa Quality assurance label Jun 2, 2023
@lasarojc lasarojc merged commit 12866ce into v0.38.x Jun 2, 2023
@lasarojc lasarojc deleted the mergify/bp/v0.38.x/pr-888 branch June 2, 2023 12:02
@faddat faddat mentioned this pull request Oct 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lasarojc lasarojc lasarojc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lasarojc lasarojc

Labels
qa Quality assurance
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lasarojc