Extend the infrastructure provider with StartNodes and StopTestnet (backport #796)
#845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#796) * shim in start and stop methods * rename to 'tendermint' * rename to 'kill tendermint' * add terminate vs kill * add command package * add param names * switch exec compose to docker pkg * all exec switched to docker package * remove runner exec * functionality in place for start kill terminate * exec compose takes context * compose verbose takes context * docker.exec takes context * add create node to infra provider * start and create calls replaced with infra provider * commit exec pkg * add ssh pkg * add digital ocean package * add client creation logic * use ssh agent to auth to remote * plump infra data into tests * move agent socket dial to client connection creation * error if auth sock not defined * allow unknown hosts to be accessed * return session error * close connection in ssh exec * gofmt * use IP.Equal instead of bytes.Equal * correct the nolint comment format * remove backup for INFRASTRUCTURE_DATA missing * Update test/e2e/pkg/infra/digitalocean/digitalocean.go Co-authored-by: Thane Thomson <connect@thanethomson.com> * remove hostkeyalgorithm setting * rename IP node field * add external address field * use external IP in digital ocean * use correct variable in e2e compose * use --no-start * Fix reachable IPs on docker * Rename to CometBFT * Simplify Path * Revert GetReachableIP * Improve ext IP * Remove CreateNode * Adapt provider interface to actual needs * Minor in digitalocean * Doc * Fix contexts * Update test/e2e/pkg/infra/digitalocean/digitalocean.go * Update test/e2e/pkg/exec/exec.go Co-authored-by: Lasaro <lasaro@informal.systems> * Remove `cli.ifd`, first version * Remove `cli.ifd`, reduce duplication * Remove references to Docker in help strings --------- Co-authored-by: William Banfield <wbanfield@gmail.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems> (cherry picked from commit 0070a86)
sergio-mena
approved these changes
May 16, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #796 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com