Skip to content

ABCI calls should crash/exit in all cases when the call itself reports and error (backport #496) #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2023
Merged

ABCI calls should crash/exit in all cases when the call itself reports and error (backport #496) #520

merged 5 commits into from
Mar 15, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 13, 2023

This is an automatic backport of pull request #496 done by Mergify.
Cherry-pick of 2ab8598 has failed:

On branch mergify/bp/v0.34.x/pr-496
Your branch is up to date with 'origin/v0.34.x'.

You are currently cherry-picking commit 2ab859860.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/bug-fixes/496-error-on-applyblock-should-panic.md
	modified:   consensus/state.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/govulncheck.yml
	both modified:   state/execution.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@sergio-mena @mergify
ABCI calls should crash/exit in all cases when the call itself report…
d2fae79 
…s and error (#496)

* Review call hierarchies of ABCI methods to make sure they panic on error

* Added changelog

* Trying 1.20.2 explicitly

(cherry picked from commit 2ab8598)

# Conflicts:
#	.github/workflows/govulncheck.yml
#	state/execution.go
@mergify mergify bot requested a review from a team as a code owner March 13, 2023 15:29
@mergify mergify bot added the conflicts label Mar 13, 2023
@sergio-mena
Revert "ABCI calls should crash/exit in all cases when the call itsel…
c210eff 
…f reports and error (#496)"

This reverts commit d2fae79.
@sergio-mena
[partial cherry-pick] ABCI calls should crash/exit in all cases when …
4290819 
…the call itself reports and error (#496)

* Review call hierarchies of ABCI methods to make sure they panic on error

* Added changelog

* Trying 1.20.2 explicitly
@sergio-mena
Merge branch 'v0.34.x' into mergify/bp/v0.34.x/pr-496
1cdc9d7
@sergio-mena
Merge branch 'v0.34.x' into mergify/bp/v0.34.x/pr-496
b310553
@sergio-mena sergio-mena self-assigned this Mar 15, 2023
@sergio-mena sergio-mena added abci Application blockchain interface and removed conflicts labels Mar 15, 2023
@sergio-mena sergio-mena merged commit ca09456 into v0.34.x Mar 15, 2023
@sergio-mena sergio-mena deleted the mergify/bp/v0.34.x/pr-496 branch March 15, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sergio-mena sergio-mena sergio-mena approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sergio-mena sergio-mena

Labels
abci Application blockchain interface
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergio-mena