-
Notifications
You must be signed in to change notification settings - Fork 683
Post-release root docs update #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@@ -0,0 +1,2 @@ | |||
- Use Go 1.19 to build CometBFT, since Go 1.18 has reached end-of-life. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is #385 listed below, I'm not sure including this done achieves anything (think of a user reading these). It could even be misleading.
I'd remove this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: let's say we backport something (next week) from |
This is a good question. I've been thinking about this recently, and I would say that we should probably only add changelog entries to PRs in two cases:
This way, when we cut a new release, it's easy to just copy across all the I'll see if there's an easy way to codify this in our PR template and contributing guidelines. |
Updates our root changelog and upgrading guidelines on
main
to sync them with what we have onv0.34.x
andv0.37.x
.Also makes a few minor changes to the README.
PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments