e2e: fix Makefile to produce commit_hash for builtin #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanethomson
approved these changes
Mar 2, 2023
| @@ -0,0 +1,2 @@ | |||
| - `[e2e]` Fixed the Makefile logic so that builtin e2e nodes have a commit hash. | |||
There was a problem hiding this comment.
Do we need changelog entries for the E2E tests? Generally changelog entries should be relevant to users. Would this be targeting consensus engine developers perhaps?
There was a problem hiding this comment.
You're right, let me remove it
This reverts commit 6c9a683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430
Extracted some Makefile logic into a common file (rather than copy-pasting) so that the e2e node is built with the flags allowing it to have a commit hash.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments