Skip to content

config: remove block_sync key #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2023
Merged

config: remove block_sync key #415

merged 10 commits into from
Mar 6, 2023

Conversation

hvanz
Copy link
Member

@hvanz hvanz commented Feb 28, 2023 •
edited
Loading

Part of #409

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@hvanz hvanz added block-sync breaking A breaking change labels Feb 28, 2023
@hvanz hvanz self-assigned this Feb 28, 2023
@hvanz hvanz mentioned this pull request Mar 1, 2023
Closed
2 tasks
@hvanz hvanz changed the title Remove BlockSyncMode config config: remove block_sync key Mar 1, 2023
@hvanz hvanz marked this pull request as ready for review March 1, 2023 09:59
@hvanz hvanz requested a review from a team as a code owner March 1, 2023 09:59
sergio-mena
sergio-mena reviewed Mar 1, 2023
View reviewed changes
sergio-mena
sergio-mena reviewed Mar 1, 2023
View reviewed changes
sergio-mena
sergio-mena reviewed Mar 1, 2023
View reviewed changes
hvanz and others added 2 commits March 2, 2023 08:31
@hvanz @sergio-mena
Update docs/core/block-sync.md
2d77ab2 
Co-authored-by: Sergio Mena <sergio@informal.systems>
@hvanz
BlockSyncVersion cannot be empty
59a6123
sergio-mena
sergio-mena approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hvanz hvanz merged commit 304f3a3 into main Mar 6, 2023
@hvanz hvanz deleted the hernan/409-remove-blocksyncmode branch March 6, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sergio-mena sergio-mena sergio-mena approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hvanz hvanz

Labels
block-sync breaking A breaking change
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvanz @sergio-mena