Skip to content

fix(privval): retry accepting a connection on errors (backport #2047) #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix(privval): retry accepting a connection on errors (backport #2047) #3899

merged 2 commits into from
Aug 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2024

Before the change, we'd error after just 1 attempt of accepting a connection.

Co-authored by: @corverroos

Closes #452

Port of corverroos/tendermint#1

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
This is an automatic backport of pull request #2047 done by [Mergify](https://mergify.com).

@melekes @mergify
fix(privval): retry accepting a connection on errors (#2047)
66afad6 
Before the change, we'd error after just 1 attempt of accepting a
connection.

Co-authored by: @corverroos

Closes #452

Port of corverroos/tendermint#1

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments

(cherry picked from commit a8991d6)

# Conflicts:
#	.changelog/v0.37.5/bug-fixes/2047-privval-retry-accepting-conn.md
@mergify mergify bot requested a review from a team as a code owner August 30, 2024 07:54
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 30, 2024

Cherry-pick of a8991d6 has failed:

On branch mergify/bp/v0.37.x/pr-2047
Your branch is up to date with 'origin/v0.37.x'.

You are currently cherry-picking commit a8991d63e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   privval/signer_listener_endpoint.go
	modified:   privval/signer_listener_endpoint_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	added by them:   .changelog/v0.37.5/bug-fixes/2047-privval-retry-accepting-conn.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 30, 2024
@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
3 tasks
@mergify mergify bot merged commit 340dfdc into v0.37.x Aug 30, 2024
21 checks passed
@mergify mergify bot deleted the mergify/bp/v0.37.x/pr-2047 branch August 30, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melekes