revert: Partly undo ADR 109 by re-exporting store & state packages #2709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partly undoes the changes in #1605 by re-exporting the store/ package.
4 tasks
|
todo: remember to mark the packages as deprecated to signal we will potentially make them private in future releases |
mergify bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
…2709) This partly undoes the changes in #1605 by re-exporting the store/ package. Closes #2610 Paging @tac0turtle to check if this can help Cosmos SDK continue migration to Comet v1 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 7d230d7)
4 tasks
melekes
pushed a commit
that referenced
this pull request
Apr 16, 2024
…ackport #2709) (#2821) This partly undoes the changes in #1605 by re-exporting the store/ package. Closes #2610 Paging @tac0turtle to check if this can help Cosmos SDK continue migration to Comet v1 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2709 done by [Mergify](https://mergify.com). Co-authored-by: Adi Seredinschi <adizere@gmail.com>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
Please note that I didn't use the `Deprecated` keyword because doing this would result in many warnings for us and our users. Follow-up to #2709 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Daniel <daniel.cason@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
Please note that I didn't use the `Deprecated` keyword because doing this would result in many warnings for us and our users. Follow-up to #2709 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 627b6e7)
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 17, 2024
…2828) Please note that I didn't use the `Deprecated` keyword because doing this would result in many warnings for us and our users. Follow-up to #2709 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2822 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly undoes the changes in #1605 by re-exporting the store/ and /state packages.
Closes #2610
Paging @tac0turtle to check if this can help Cosmos SDK continue migration to Comet v1
PR checklist
Tests written/updated.changelog(we use unclog to manage our changelog)Updated relevant documentation (docs/orspec/) and code comments