Skip to content

fix(Makefile): gofumpt no longer needed (backport #2235) #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(Makefile): gofumpt no longer needed (backport #2235) #2239

merged 2 commits into from
Feb 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 5, 2024

This is an automatic backport of pull request #2235 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@melekes @mergify
fix(Makefile): gofumpt no longer needed (#2235)
ac2d7c6 
It looks like `go generate -run="./scripts/mockery_generate.sh" ./...`
produces correctly formatted (from `gofumpt` perspective) output.

Closes #2212

(cherry picked from commit f92bace)
@mergify mergify bot requested a review from a team as a code owner February 5, 2024 10:25
@mergify mergify bot requested a review from a team February 5, 2024 10:25
@melekes melekes merged commit 13f06e4 into v1.x Feb 5, 2024
@melekes melekes deleted the mergify/bp/v1.x/pr-2235 branch February 5, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melekes