Skip to content

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jan 30, 2024

Manual backport of #1829

…t for the new grammar. (#1829)

* new grammar

* new grammar

* remove two grammars

* Update spec/abci/abci++_comet_expected_behavior.md

Co-authored-by: Sergio Mena <sergio@informal.systems>

* typo

* minor

* info explanation added

* ADR modified

* Fix linter error

---------

Co-authored-by: nenadmilosevic95 <nenad@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
@melekes melekes requested review from a team as code owners January 30, 2024 07:00
@melekes melekes requested a review from a team January 30, 2024 07:00
@melekes melekes changed the base branch from main to v1.x January 30, 2024 07:00
Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@melekes melekes merged commit e146cfb into v1.x Jan 30, 2024
@melekes melekes deleted the nenad/1581-address-2-faulty-abci-scenarios-found-by-e2e-tests-v1.x branch January 30, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: The new e2e tests found 2 scenarios where CometBFT is not respecting ABCI 1.0 grammar.
3 participants