feat(light): export errors #1904
Conversation
|
Thanks for this @Halimao. The team was away and we're back as of today - will review soon! |
There was a problem hiding this comment.
Thank you for your submission, but in my opinion what is missing here is using (at least) the introduced errors in test units. The point of having error types is to avoid hacks in which we compare the error message with a string, when testing methods.
Please consider navigating the test units and adopting the introduced errors there. Notice that this package has lots of tests checking not only the regular operation but also the errors expected in determined circumstances.
|
@Halimao there's a few outstanding suggestions from Daniel and Anton. You feel good about pushing this through the finish line, or should someone else take over it? Thanks for the contributions so far! |
Sorry for this. I'm still working on this, but there are still many things that need to be done, and I'm busy these days. I will try my best to finish this asap, thanks. |
|
Do you mind, meanwhile, converting this PR to draft? |
|
@cason Hi sir, suggested changes have been addressed, now we are using the introduced errors in the unit tests. |
@mzabaluev Hi sir, addressed the suggestion changes |
|
Hi @Halimao, thanks for all the work. I'm taking care of this PR now and will take it to the finish line. |
…tLevelIsInvalid` and `TestValidateTrustLevel`
Partially addresses: #1140
Exports errors for
lightpackage.