Skip to content

fix: typos with spell checker #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix: typos with spell checker #1805

wants to merge 3 commits into from

Conversation

bodhi-crypo
Copy link
Contributor

@bodhi-crypo bodhi-crypo commented Dec 12, 2023 •
edited
Loading

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  1. fix all text typo with spell checker(mainly *.md)
  2. go,proto and other file types are excluded to avoid possible problems with proper nouns
  3. CI may be considered in the next step ref:https://github.com/codespell-project/codespell

@bodhi-crypo bodhi-crypo requested review from a team as code owners December 12, 2023 05:44
@bodhi-crypo bodhi-crypo requested a review from a team December 12, 2023 05:44
melekes
melekes reviewed Dec 12, 2023
View reviewed changes
@bodhi-crypo
Copy link
Contributor Author

@melekes fix some name

@hoangdv2429
Copy link
Contributor

I guess you saw my PR lol. Thanks mate!

hoangdv2429
hoangdv2429 suggested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@hoangdv2429 hoangdv2429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall everything is good. But please review changes before putting up a PR. Thanks!

@hoangdv2429 hoangdv2429 mentioned this pull request Dec 12, 2023
Merged
3 tasks
@bodhi-crypo
Copy link
Contributor Author

@hoangdv2429 resolved all thks

@thanethomson
Copy link
Contributor

Superseded by #1809.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@melekes melekes melekes left review comments

@hoangdv2429 hoangdv2429 hoangdv2429 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bodhi-crypo @hoangdv2429 @thanethomson @melekes