Skip to content

Conversation

lasarojc
Copy link
Contributor

@lasarojc lasarojc commented Nov 15, 2023

Contributes to #1620

This commit makes the test in 0.38 be the same as in main, that is, to ignore the order of transactions in the receiving reactor.
#1620 is not fixed by this PR. Once #1620 is fixed, it needs to be back ported.

#1629 does the same work as this PR, but for 0.37


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

…s the order of transactions in the receiving reactor.
@lasarojc lasarojc added backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x e2e Related to our end-to-end tests labels Nov 15, 2023
@lasarojc lasarojc self-assigned this Nov 15, 2023
@lasarojc lasarojc marked this pull request as ready for review November 15, 2023 18:32
@lasarojc lasarojc requested a review from a team as a code owner November 15, 2023 18:32
@lasarojc lasarojc mentioned this pull request Nov 15, 2023
3 tasks
@lasarojc lasarojc changed the title Fixes back port of test Fixes back port of test in 0.38 Nov 15, 2023
@lasarojc lasarojc removed the backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x label Nov 15, 2023
@lasarojc lasarojc linked an issue Nov 15, 2023 that may be closed by this pull request
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lasarojc lasarojc merged commit feb0538 into v0.38.x Nov 16, 2023
@lasarojc lasarojc deleted the lasarojc/limit_gossip_test branch November 16, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Related to our end-to-end tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

FIFO ordering is violated by the clist_mempool
2 participants