-
Notifications
You must be signed in to change notification settings - Fork 676
Merge branch main
into feature/proto-upgrade
#1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sergio-mena
merged 29 commits into
feature/proto-upgrade
from
merge/main-into-proto-upgrade
Oct 26, 2023
Merged
Merge branch main
into feature/proto-upgrade
#1539
sergio-mena
merged 29 commits into
feature/proto-upgrade
from
merge/main-into-proto-upgrade
Oct 26, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Close RPC endpoints * Replace mutex with atomic.Bool in consensus * Add waitSync to mempool reactor * Comments * Add changelog * Fix broadcastTxRoutine * Change log level to debug * Rename back to waitSync * Update changelog text * Replace ConsensusReactor by MempoolReactor in RPC * Start broadcast routines only when waitSync is false * Add new error for when endpoint is closed * Don't store pointer to atomic.Bool; change initialization * OnStart only logs if WaitSync is true * Update mempool/reactor.go Co-authored-by: Daniel <daniel.cason@informal.systems> * Update consensus/reactor.go Co-authored-by: Thane Thomson <connect@thanethomson.com> * mempool: waitSync channel to block broadcast routines * comment * Fix lint * Revert refactoring in AddPeer --------- Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Thane Thomson <connect@thanethomson.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.13.0 to 0.14.0. - [Commits](golang/crypto@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.3.0 to 0.4.0. - [Commits](golang/sync@v0.3.0...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.16.0. - [Commits](golang/net@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.26.1 to 1.27.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.26.1...v1.27.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
…#1450) Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/styfle/cancel-workflow-action/releases) - [Commits](styfle/cancel-workflow-action@0.11.0...0.12.0) --- updated-dependencies: - dependency-name: styfle/cancel-workflow-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0. - [Release notes](https://github.com/prometheus/client_model/releases) - [Commits](https://github.com/prometheus/client_model/commits/v0.5.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.26.1 to 1.27.0. - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.26.1...v1.27.0) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.17.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.16.0...v1.17.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1414) As part of porting the cosmos-sdk simulator to running on top of its testutil/network runner, we need a way to simulate adversarial network connections between validators. This change adds the existing fuzzing configuration of P2PConfig to MConnConfig and uses it to conditionally create an unreliable connection in MultiplexTransport. Co-authored-by: Elias Naur <mail@eliasnaur.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
…1462) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.34.2 to 2.35.3. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md) - [Commits](vektra/mockery@v2.34.2...v2.35.3) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: export crypto/armor errors * refactor: export crypto/ed25519 errors * refactor: export crypto/encoding errors * refactor: export crypto/xchacha20poly1305 errors * refactor: export crypto/xsalsa20symmetric errors * refactor: export crypto/sr25519 errors * refactor: export crypto/merkle errors * style: use existing convention for error names * style: remove the use of naked returns * refactor: implement errors using value receivers
#1493) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.3.0...10.0.1) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* proxy: Remove "unsynchronized" local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Expand client creator interface Expand the `ClientCreator` interface to allow the caller to explicitly specify the "connection" whose client they are creating. This potentially gives greater control over the concurrency model employed in each type of connection. Signed-off-by: Thane Thomson <connect@thanethomson.com> * abci/client: Clarify NewLocalClient description Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Add connection-synchronized local client creator Analogous to the old "unsynchronized" local client creator. Signed-off-by: Thane Thomson <connect@thanethomson.com> * abci/client: Add unsynchronized local client Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Add consensus-synchronized local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Fix mock configuration in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove changelog entry - no longer necessary Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Add unsynchronized local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * changelog: Add entry for unsync local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update 1141-abci-unsync-proxy.md Co-authored-by: Adi Seredinschi <adizere@gmail.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Adi Seredinschi <adizere@gmail.com>
* Make BuildExtendedCommitInfo public * Make BuildLastCommitInfo exported * Fix validator set heights * Split BuildCommitInfo functions into public and private parts * Fix name in comment for buildLastCommitInfoFromStore * Add doc comments for public Build_CommitInfo functions
…1497) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.35.3 to 2.35.4. - [Release notes](https://github.com/vektra/mockery/releases) - [Changelog](https://github.com/vektra/mockery/blob/master/docs/changelog.md) - [Commits](vektra/mockery@v2.35.3...v2.35.4) --- updated-dependencies: - dependency-name: github.com/vektra/mockery/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.2 to 1.58.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.2...v1.58.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.16.0 to 0.17.0. - [Commits](golang/net@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karolos Antoniadis <karolos@informal.systems>
) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.27.0 to 1.27.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.27.0...v1.27.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Initial attempt to decrease the flakiness * Remove loop over blocks from archive nodes * Removed needless loop through blocks * removed the first block test (#1492) --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
sergio-mena
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1330
Merged from
main
again to fix newly emerged lints and eliminate test flakiness.No significant changes.