state: node bootstrap in v0.37.x #1514

jmalicevic · 2023-10-19T14:32:25Z

Manual backport of #1057
Closes #1513

PR checklist

Tests written/updated
Changelog entry added in .changelog (we use unclog to manage our changelog)
Updated relevant documentation (docs/ or spec/) and code comments

* add bootstrap state cmd * add a missing line * Initial API impl * Added error message for missing appHash * Added changelog, removed cli * Added PR number * Unified hex encoding with rest of the code * Applied PR review comments * Proper blockstore initialization in case of offline statesync * Reverted forcing blocksync, not needed for correct operation * Added changelog and comments * Removed printfs, added check for empty state store * Fixed linter * Apply minor suggestions from code review Co-authored-by: Thane Thomson <connect@thanethomson.com> * Moved the appHash check up * Apply minor suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Fixed linter * Do not look for VE when starting up after offline statesync * Extracted check for offline statesync outside load commit * Reconstruct seen commit after offline statesync * Call reconstructSeenCommit from reconstructLastCommit * Reading offline statesync height only once and passing it as a parameter * Moved up option initialization to make sure offline statesync is enabled * Added error to panic message * Update consensus/state.go Co-authored-by: Sergio Mena <sergio@informal.systems> * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Adjusted new lines * Added unit test to test int conversion and fixed linter * Apply suggestions from code review Co-authored-by: Thane Thomson <connect@thanethomson.com> * Replaced closing ifs with defer, added errors to error messages * linter fix * Adapted bootstrap code to use proper genesis file functions * Reverted genesis doc changes * Moved deferred closing before checking for whether the store is empty * Moved deferred close before error check --------- Co-authored-by: HuangYi <huang@crypto.com> Co-authored-by: yihuang <yi.codeplayer@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Sergio Mena <sergio@informal.systems>

state/store.go

consensus/state.go

state/store.go

blocksync/reactor.go

…d for the store

Co-authored-by: Sergio Mena <sergio@informal.systems>

sergio-mena

LGTM, thanks for this

* node/state:bootstrap state api (cometbft#1057) * add bootstrap state cmd * add a missing line * Initial API impl * Added error message for missing appHash * Added changelog, removed cli * Added PR number * Unified hex encoding with rest of the code * Applied PR review comments * Proper blockstore initialization in case of offline statesync * Reverted forcing blocksync, not needed for correct operation * Added changelog and comments * Removed printfs, added check for empty state store * Fixed linter * Apply minor suggestions from code review Co-authored-by: Thane Thomson <connect@thanethomson.com> * Moved the appHash check up * Apply minor suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Fixed linter * Do not look for VE when starting up after offline statesync * Extracted check for offline statesync outside load commit * Reconstruct seen commit after offline statesync * Call reconstructSeenCommit from reconstructLastCommit * Reading offline statesync height only once and passing it as a parameter * Moved up option initialization to make sure offline statesync is enabled * Added error to panic message * Update consensus/state.go Co-authored-by: Sergio Mena <sergio@informal.systems> * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Adjusted new lines * Added unit test to test int conversion and fixed linter * Apply suggestions from code review Co-authored-by: Thane Thomson <connect@thanethomson.com> * Replaced closing ifs with defer, added errors to error messages * linter fix * Adapted bootstrap code to use proper genesis file functions * Reverted genesis doc changes * Moved deferred closing before checking for whether the store is empty * Moved deferred close before error check --------- Co-authored-by: HuangYi <huang@crypto.com> Co-authored-by: yihuang <yi.codeplayer@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Sergio Mena <sergio@informal.systems> * Fixed cherry pick conflicts * Removed go API changes in state store * Remove breaking go API changes in the blocksync reactor * Removed breaking changelog and fixed mocks * [pair programming] Found a more readable way to add the methods needed for the store * Removed duplicated code from blocksync reactor * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Removed comments * Removed unused variable from state --------- Co-authored-by: HuangYi <huang@crypto.com> Co-authored-by: yihuang <yi.codeplayer@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Sergio Mena <sergio@informal.systems>

jmalicevic and others added 4 commits October 17, 2023 22:13

Fixed cherry pick conflicts

4153ff3

Removed go API changes in state store

8fb9eca

Remove breaking go API changes in the blocksync reactor

4794f9c

jmalicevic added enhancement New feature or request state state-sync labels Oct 19, 2023

jmalicevic added this to the 2023-Q4 milestone Oct 19, 2023

jmalicevic self-assigned this Oct 19, 2023

jmalicevic added 2 commits October 19, 2023 16:36

Removed breaking changelog and fixed mocks

ff8d61e

Merge branch 'v0.37.x' into jasmina/node_bootstrap_api_backport_0.37

583fa04