grpc: backport Add Close method to gRPC client (#1251) to v0.38.x-experimental
#1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No conflicts, automatic backport of #1251. |
jmalicevic
approved these changes
Oct 11, 2023
20f1e0c to
579b18c
Compare
* grpc: Add close method to client Signed-off-by: Thane Thomson <connect@thanethomson.com> * grpc: Add close method to privileged client Signed-off-by: Thane Thomson <connect@thanethomson.com> * test/e2e: Close gRPC clients after testing Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
579b18c to
d27b2b4
Compare
lasarojc
pushed a commit
that referenced
this pull request
Nov 13, 2023
* grpc: Add close method to client * grpc: Add close method to privileged client * test/e2e: Close gRPC clients after testing --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1419:
Should not conflict with #1473, so they can be merged in any order.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments