Flaky TestProvider test #1582
Description
Bug Report
The modification of the prunning code has TestProvider test flaky.
The code was changed to address the flakiness but it wasn't enough, as shown in the following snippet from https://github.com/cometbft/cometbft/actions/runs/6796991125/job/18478177653?pr=1558
ok github.com/cometbft/cometbft/light 67.678s coverage: 78.8% of statements
CometBFT running!
E[2023-11-08|10:34:21.264] Error serving server err="accept tcp 127.0.0.1:40299: use of closed network connection"
E[2023-11-08|10:34:21.264] Error starting gRPC server err="accept tcp 127.0.0.1:42083: use of closed network connection"
E[2023-11-08|10:34:21.264] Error starting privileged gRPC server err="accept tcp 127.0.0.1:35771: use of closed network connection"
E[2023-11-08|10:34:21.267] Stopped accept routine, as transport is closed module=p2p numPeers=0
E[2023-11-08|10:34:21.267] Failed to save AddrBook to file module=p2p book=/tmp/-_home_runner_work_cometbft_cometbft_light_provider_http_2218041770/config/addrbook.json file=/tmp/-_home_runner_work_cometbft_cometbft_light_provider_http_2218041770/config/addrbook.json err="rename /tmp/-_home_runner_work_cometbft_cometbft_light_provider_http_2218041770/config/write-file-atomic-06770805029005217365 /tmp/-_home_runner_work_cometbft_cometbft_light_provider_http_2218041770/config/addrbook.json: no such file or directory"
CometBFT running!
E[2023-11-08|10:34:40.807] Stopped accept routine, as transport is closed module=p2p numPeers=0
E[2023-11-08|10:34:40.807] Error serving server err="accept tcp 127.0.0.1:34245: use of closed network connection"
E[2023-11-08|10:34:40.807] Error starting gRPC server err="accept tcp 127.0.0.1:33719: use of closed network connection"
E[2023-11-08|10:34:40.807] Error starting privileged gRPC server err="accept tcp 127.0.0.1:39465: use of closed network connection"
CometBFT running!
E[2023-11-08|10:34:50.919] Failed to prune blocks module=state err="failed to prune states to height 1: from height 1 must be lower than to height 1" targetRetainHeight=1 newRetainHeight=1
E[2023-11-08|10:35:00.353] Stopped accept routine, as transport is closed module=p2p numPeers=0
E[2023-11-08|10:35:00.354] Error serving server err="accept tcp 127.0.0.1:36331: use of closed network connection"
E[2023-11-08|10:35:00.354] Error starting gRPC server err="accept tcp 127.0.0.1:35409: use of closed network connection"
E[2023-11-08|10:35:00.354] Error starting privileged gRPC server err="accept tcp 127.0.0.1:35013: use of closed network connection"
CometBFT running!
E[2023-11-08|10:35:19.900] Stopped accept routine, as transport is closed module=p2p numPeers=0
E[2023-11-08|10:35:19.900] Error serving server err="accept tcp 127.0.0.1:34243: use of closed network connection"
E[2023-11-08|10:35:19.900] Error starting gRPC server err="accept tcp 127.0.0.1:40419: use of closed network connection"
E[2023-11-08|10:35:19.900] Error starting privileged gRPC server err="accept tcp 127.0.0.1:34339: use of closed network connection"
--- FAIL: TestProvider (78.20s)
http_test.go:64:
Error Trace: /home/runner/work/cometbft/cometbft/light/provider/http/http_test.go:64
Error: Should be true
Test: TestProvider
FAIL