Bug Report

The e2e tests are being skipped and not executed due to the bug. Basically, added logic that should differentiate between different environments (docker, digital ocean, etc.) has a bug that causes the tests to be skipped.

Setup

CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source): main a09f5d3

Have you tried the latest version: yes

ABCI app (name for built-in, URL for self-written if it's publicly available): default

Environment:

• OS (e.g. from /etc/os-release): N/A
• Install tools: N/A
• Others: N/A

node command runtime flags: N/A

Config N/A

What happened?

While trying to run new abci tests, I realised that the tests were not being executed.

What did you expect to happen?

The test I was expecting to fail was passing. After a closer look, I realised that the tests were skipped. However, the runner
shows the output as if all tests are being executed and all pass.

How to reproduce it

Just add t.Error("Hello") in any test and start the runner with any testnet. Apart from Hello error message, it will show also
INFRASTRUCTURE_DATA not set and INFRASTRUCTURE_TYPE is not docker message. If you see where in the code this is printed you will find this part of the code in the test/e2e/tests/e2e_test.go lines 76-80.

ifdType := os.Getenv("INFRASTRUCTURE_DATA")
ifdFile := os.Getenv("INFRASTRUCTURE_FILE")
if ifdFile == "" && ifdType != "docker" {
	t.Skip("INFRASTRUCTURE_DATA not set and INFRASTRUCTURE_TYPE is not docker")
}
 

The setting of variables and conditions needs to be revisited! In addition, to this specific part of the code, we should recheck all the places in the code related to the variables INFRASTRUCTURE_DATA, INFRASTRUCTURE_FILE and INFRASTRUCTURE_TYPE.

Logs N/A

dump_consensus_state output N/A

Anything else we need to know N/A