With proguard config for parcelable class #3245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3245 +/- ##
======================================
Coverage 6.09% 6.09%
======================================
Files 270 270
Lines 11608 11608
Branches 906 906
======================================
Hits 707 707
Misses 10844 10844
Partials 57 57Continue to review full report at Codecov.
|
neslihanturan
approved these changes
Nov 29, 2019
|
@nes: Do not hesitate to upload any pic via Nearby, just modify the name
during upload, and unlink from Wikidata after upload 🙂
…On Sat, 30 Nov 2019, 15:09 Josephine Lim, ***@***.***> wrote:
Merged #3245
<#3245> into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3245?email_source=notifications&email_token=AAAYKBQCSNI4WJAC74323ILQWH7Q7A5CNFSM4JTC3QM2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVFWQUAA#event-2842495488>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAYKBQDSEFVAJ3HAR65BGTQWH7Q7ANCNFSM4JTC3QMQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Probably fixes #3244
What changes did you make and why?
https://stackoverflow.com/questions/21342700/proguard-causing-runtimeexception-unmarshalling-unknown-type-code-in-parcelabl
Tests performed (required)
Couldn't test it as I couldn't build a release APK for prod. @misaochan can you try this fix and see if it works.