Add common-voice-network Docker network
#4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a second network to allow other services to connect into this network and also for this network to connect out to them.
|
Size Change: +3 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
moz-dfeller
reviewed
Jul 18, 2025
There was a problem hiding this comment.
You'll need to add the network to the DB at least as well, right?
There was a problem hiding this comment.
Oh yes. I misread the file and attached to the redis container by accident.
Fixed.
Remove from redis as not needed there.
moz-dfeller
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a second network to allow other Docker projects to connect their services to the
common-voice-networkand so communicate together.