1188 create endpoint to create client credentials #4971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -13 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
|
Now we have a third - outside API concept (after API's in BE & FE), maybe naming is more critical. And adding some comments what the API is about. IMO "PublicAPI" does not cut it. |
This is an immutable endpoint, so it will always return 204 regardless of whether the client_id to to delete has already been deleted or not. It will only attempt to delete a client_id that belongs to this user.
|
Fabulous job @akrabat, thanks! 🚀 |
moz-dfeller
commented
Jul 12, 2025
Comment on lines
+4
to
+10
| export const deleteClientCredentialsCommandHandler = async ( | ||
| cmd: DeleteClientCredentialsCommand | ||
| ) => { | ||
| await deleteClientCredentials({ | ||
| ...cmd, | ||
| }) | ||
| } |
There was a problem hiding this comment.
You're using async/await syntax here but you're not doing anything with the result of the deleteClientCredentials function call, so you might as well just return the Promise straight to the caller. That's the only thing I think might be unnecessary. Everything else is 🥇
It's also just a comment, feel free to ignore it. The compiler is going to optimize this away anyways.
Suggested change
| export const deleteClientCredentialsCommandHandler = async ( | |
| cmd: DeleteClientCredentialsCommand | |
| ) => { | |
| await deleteClientCredentials({ | |
| ...cmd, | |
| }) | |
| } | |
| export const deleteClientCredentialsCommandHandler = ( | |
| cmd: DeleteClientCredentialsCommand | |
| ) => { | |
| return deleteClientCredentials({ | |
| ...cmd, | |
| }) | |
| } |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating endpoints to handle API client credentials creation.