-
Notifications
You must be signed in to change notification settings - Fork 859
Tagging keys and redesigned guidelines #4952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,828
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add translation keys for tagging page * Add guidelines and toast messages to tagging page
* Add guidelines for scripted and spontaneous speech, enhance UI components, and implement new sidebar content * feat(guidelines-page): Add guidelines for code switching and reporting content; refactor sidebar components * feat(guidelines): Enhance guidelines with new sections and sidebar navigation; improve question validation * Refactor guidelines for code-switching and sidebar navigation - Updated the guidelines in the FTL files to enhance clarity and organization, including new sections on adding questions and what to avoid. - Refactored the SidebarNavSection component to improve visibility toggling for sections. - Removed the SidebarNavItem component as its functionality was integrated into SidebarNavSection. - Updated constants for code-switching items to reflect new guideline structure. - Expanded the CodeSwitching component to include detailed instructions and examples for transcribing and tagging code-switched speech. - Adjusted the ReportingContent component to maintain consistent styling. * fix: Update React import syntax and enhance sidebar navigation styles * fix: Update React import statements to use namespace import syntax
Size Change: +5.23 kB (+0.08%) Total Size: 6.88 MB
ℹ️ View Unchanged
|
…useScrollToGuidelinesSection
ftyers
reviewed
Aug 4, 2025
web/locales/spontaneous-speech/en/pages/contribution/code-switching.ftl
Outdated
Show resolved
Hide resolved
ftyers
reviewed
Aug 4, 2025
web/locales/spontaneous-speech/en/pages/contribution/code-switching.ftl
Outdated
Show resolved
Hide resolved
ftyers
reviewed
Aug 4, 2025
web/locales/spontaneous-speech/en/pages/contribution/code-switching.ftl
Outdated
Show resolved
Hide resolved
ftyers
reviewed
Aug 4, 2025
web/locales/spontaneous-speech/en/pages/contribution/code-switching.ftl
Outdated
Show resolved
Hide resolved
ftyers
reviewed
Aug 4, 2025
web/locales/spontaneous-speech/en/pages/contribution/code-switching.ftl
Outdated
Show resolved
Hide resolved
ftyers
reviewed
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments about phrasing, feel free to tag me to review any new versions.
@ftyers, I applied the changes, thank you. Are all others (non-CS) OK already? |
Verbally confirmed to go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds keys for tagging page + redesigned guidelines page