-
Notifications
You must be signed in to change notification settings - Fork 859
1157- Backend to retrieve sentences & clips without variant when variant ones run out #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
moz-bozden
merged 6 commits into
main
from
1157-mcv-be-retrieve-sentencesclips-without-variant
Jun 11, 2025
Merged
1157- Backend to retrieve sentences & clips without variant when variant ones run out #4931
moz-bozden
merged 6 commits into
main
from
1157-mcv-be-retrieve-sentencesclips-without-variant
Jun 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +22 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
moz-dfeller
requested changes
Jun 11, 2025
moz-dfeller
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user sets a variant and "show only sentences/clips from my variant", the system shows "you are out of sentences/clips".
We want to give an option to the user to continue with sentences/clips from any variant (including those without any variant).
This PR handles the backend of this with an
ignoreClientVariant=truequery parameter (default false) which should be called from front-end after a button click.