Fix where client_id is returning null and throwing a TypeError
#4920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…present as the client_id is necessary for getting the contribution activity
client_id is returning null and throwing a TypeErrorclient_id is returning null and throwing a TypeError
|
Size Change: +5 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
added 2 commits
June 5, 2025 21:34
…ault values for client_id which defaults to null to prevent TypeError being thrown
moz-dfeller
requested changes
Jun 11, 2025
| session: { | ||
| user: { client_id }, | ||
| }, | ||
| session: { user: { client_id = null } = {} } = {}, | ||
| params: { id }, | ||
| } = request | ||
| await this.model.db.createSkippedSentence(id, client_id) |
There was a problem hiding this comment.
Throw 400 here, since we need the client_id to create a meaningful entry
There was a problem hiding this comment.
Confirming this is addressed in commit 38fcf9d
…return to 400 response in createLanguageRequest()
Co-authored-by: Dmitrij Feller <119537889+moz-dfeller@users.noreply.github.com>
Co-authored-by: Dmitrij Feller <119537889+moz-dfeller@users.noreply.github.com>
|
Confirming I have addressed all the review comments, and the additional one we chatted about just now, @moz-dfeller. Now sending for review again. |
client_id is returning null and throwing a TypeErrorclient_id is returning null and throwing a TypeError
moz-dfeller
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
Related Sentry errors and files modified
Link to error in Sentry
TypeError Cannot destructure property 'client_id' of '(intermediate value)(intermediate value)(intermediate value)' as it is undefined.srv/src/lib/api.tsin functionGetContributionActivityLink to error in Sentry
TypeError Cannot read properties of undefined (reading 'client_id')/code/server/src/lib/clip.tsinClip.saveClipat line 198:17Link to error in Sentry
TypeError Cannot read properties of undefined (reading 'client_id')/code/server/src/lib/api.tsinAPI.createSkippedSentenceat line 276:17Link to error in Sentry
Cannot set headers after they are sent to the client/code/server/src/lib/clip.tsinserveClipLeaderboardat line 413Acknowledging contributors