Use "variant name [variant tag]" format everywhere (review, write, profile) #4865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moz-dfeller
requested changes
Apr 14, 2025
There was a problem hiding this comment.
Hey @HarikalarKutusu, looks good for me from the backend perspective. There are FE tests that are failing though and have to be fixed and one merge conflict (due to the recent random sentences update).
|
Missed one test :( @moz-rotimib, any comment/request is very much welcome. |
moz-rotimib
reviewed
Apr 14, 2025
.../contribution/sentence-collector/write/sentence-input-and-rules/sentence-input-and-rules.tsx
Outdated
Show resolved
Hide resolved
moz-rotimib
reviewed
Apr 14, 2025
moz-dfeller
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/implements:
[BUG]
variant_tokenis used instead ofvariant_namein the Review screen #4840 (this time for real).[BUG] Bad source for variant name translations (should get from database) #4721
Also removes translation warnings in the console.
TO-CHECK: Effect of variant related settings in the profile => Added a commit to handle that case (see note below)
TO-DO: Better layout and test with different length sentences => seems OK
@moz-dfeller & @moz-rotimib :
Selectcomponent interface is a bit limiting, but can be fixed in refactoring.Large screen with long textual parts test (seems OK):
Same on smaller screens (seems OK):
Profile:
Write:
