Add variant metadata for sva sentences per #4750
#4859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 6.87 MB ℹ️ View Unchanged
|
moz-dfeller
requested changes
Apr 14, 2025
There was a problem hiding this comment.
Hey @moz-kathyreid, thanks for the migration. I tested it and it works somewhat. If you run each individual update statement separately it works but if you try to run all at once it crashes. This is basically what you did by putting all update statements into one query. You have to run each update statement as a separate query, i.e.
export const up = async function (db: any): Promise<any> {
await db.runSql('update one')
await db.runSql('update two')
...
}then it will work as expected 👍
|
Don't review this yet, it's still failing on |
sva sentences per #4750sva sentences per #4750
added 2 commits
April 16, 2025 20:03
…ully Parse error was due to missing `"` and a doubled `""` ...
sva sentences per #4750sva sentences per #4750
|
This is now ready for review. The way I approached this was:
I believe this can now be reviewed and merged, and apologies for the stuffing around, I should have been more thorough the first time. |
moz-dfeller
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
Testing done
docker compose upto validate.tsfile is syntactically correct, however it has no impact on my dev db because thesvasentences are not loaded there (were imported in bulk). So I can't guarantee that the update works as intended, just that the SQL itself is syntactically correct.Acknowledging contributors
Many thanks to @razmikb for doing the hard work of assigning each sentence to a variant in the spreadsheet.