Skip to content

Fix: Change accents separator to "|" from default "," in bundles/metadata #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Fix: Change accents separator to "|" from default "," in bundles/metadata #4844

merged 1 commit into from
Jun 23, 2025

Conversation

HarikalarKutusu
Copy link
Contributor

@HarikalarKutusu HarikalarKutusu commented Mar 26, 2025 •
edited
Loading

This should fix #4794

  • Not tested on live data (I don't have it on local dev env)!
  • TODO: We need to put a note in cv_dataset repo's CHANGELOG.md for this change.
  • NOTE: Older releases will not be affected, so one should check dataset version to determine the separator in post-processing scripts.

@HarikalarKutusu HarikalarKutusu requested a review from a team as a code owner March 26, 2025 16:01
@HarikalarKutusu HarikalarKutusu requested review from moz-dfeller and removed request for a team March 26, 2025 16:01
@HarikalarKutusu HarikalarKutusu mentioned this pull request Apr 3, 2025
Closed
@moz-bozden moz-bozden merged commit f51115b into common-voice:main Jun 23, 2025
@moz-bozden moz-bozden deleted the fix-accent-list-comma-problem-in-bundler branch June 23, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moz-dfeller moz-dfeller moz-dfeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Change "accents" separator to a more special character
3 participants
@HarikalarKutusu @moz-dfeller @moz-bozden