Fix: Remove variables and revise wording in goals page which crashes in some languages #4811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, less complex. If you are okay with that @ftyers , I'm happy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3907
In goals page, there is a complex structure which crashes the page in some languages because of unnecessarily added plurals/variables to the i10n sentence, which creates a thousand possibilities for Fluent. But the variables are not variables, just passed as constants.
Also the calculations are based on 10k hours what could be valid in 2018, but not nowadays. And it also depends on many other variables as explained here:
#3907 (comment)
So, this PR just makes it a single fixed value string with more recent requirements.
Credit goes to @eemeli