Added in workaround in DEVELOPMENT.md for docker permissions fix for Ubuntu
#4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still wonder if we should consider a broader fix like: We could update the docker-compose.yaml file to have: but I don't know how that works in with the GCP infrastructure. |
|
Size Change: 0 B Total Size: 6.68 MB ℹ️ View Unchanged
|
moz-dfeller
requested changes
Feb 21, 2025
docs/DEVELOPMENT.md
Outdated
Comment on lines
126
to
139
| web | [BE] $ cd .. && node --trace-warnings server/js/main.js | ||
| web | [BE] Could not load config.json, using defaults (error message: ENOENT: no such file or directory, open './config.json') | ||
| web | [BE] unhandled promise rejection TypeError: Cannot read properties of null (reading 'includes') | ||
| web | [BE] at resolveWellKnownUri (/code/node_modules/openid-client/lib/issuer.js:179:23) | ||
| web | [BE] at Function.discover (/code/node_modules/openid-client/lib/issuer.js:142:26) | ||
| web | [BE] at setupAuthRouter (/code/server/src/auth-router.ts:36:34) | ||
| web | [BE] at Server.setupApp (/code/server/src/server.ts:125:36) | ||
| web | [BE] at runServer (/code/server/src/main.ts:27:18) | ||
| web | [BE] at Object.<anonymous> (/code/server/src/main.ts:34:1) | ||
| web | [BE] at Module._compile (node:internal/modules/cjs/loader:1364:14) | ||
| web | [BE] at Object.Module._extensions..js (node:internal/modules/cjs/loader:1422:10) | ||
| web | [BE] at Module.load (node:internal/modules/cjs/loader:1203:32) | ||
| web | [BE] at Function.Module._load (node:internal/modules/cjs/loader:1019:12) | ||
| web | [BE] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) |
There was a problem hiding this comment.
Hey @KathyReid , that's not an error that is related to wrong user permissions. That's just a residue from old times when some devs created their own config.json to overwrite config parameters. The right error message is something in the lines of
EACCES permission denied mkdir /code/node_modules
If possible it would be great to put the right error message here or else just remove this one, as it has nothing to do with the permissions :)
There was a problem hiding this comment.
Good call, I have removed this block and added examples of two errors observed when the permission issue occurs.
docs/DEVELOPMENT.md
Outdated
|
|
||
| The workaround is to first identify the `UID` and `GID` of the current user, then edit the line in `docker-compose.yaml` to have that `UID` and `GID`: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```sh |
There was a problem hiding this comment.
good call, thank you for flagging.
docs/DEVELOPMENT.md
Outdated
| The workaround is to first identify the `UID` and `GID` of the current user, then edit the line in `docker-compose.yaml` to have that `UID` and `GID`: | ||
|
|
||
| ``` | ||
| $ id -u |
There was a problem hiding this comment.
using > to be consistent with our other cmd line examples
Suggested change
| $ id -u | |
| > id -u |
There was a problem hiding this comment.
ah thank you for flagging
docs/DEVELOPMENT.md
Outdated
| $ id -u | ||
| 1000 | ||
|
|
||
| $ id -g |
There was a problem hiding this comment.
using > to be consistent with our other cmd line examples
Suggested change
| $ id -g | |
| > id -u |
There was a problem hiding this comment.
thank you again :-)
moz-dfeller
approved these changes
Mar 5, 2025
|
Just merged, thank you @moz-kathyreid 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Form
Type of Pull Request
A possible workaround for the following Issues:
Acknowledging contributors