Skip to content

Allow long text to fit sentence area #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HarikalarKutusu
Copy link
Contributor

@HarikalarKutusu HarikalarKutusu commented Feb 6, 2025

This fixes #4758 for most usual 1080p screens by using smaller font and smaller left/right padding, letter-spacing, and line-height values.

Note that:

  • The default 14 words/sentence (estimated from English) should be about 1.5x14 = 21 words for 15 sec recordings.
  • Although the recording limit is increased the frontend is not adapted for longer texts.
  • Frontend is most probably tested against English texts, where average word length is ~5 symbols. On the other hand we calculated ~7 symbols/word average for Kabardian (similar for Adyghe). Also many symbols are wide, like Ж Д Ш Ю

This is tested for Kabardian ON THE BROWSER for a 21 word sentence for 15 sec recordings. Here are the results:

For Speak:
image

With variant pill:
image

@HarikalarKutusu HarikalarKutusu requested a review from a team as a code owner February 6, 2025 02:22
@HarikalarKutusu HarikalarKutusu requested review from moz-rotimib and removed request for a team February 6, 2025 02:22
@moz-dfeller moz-dfeller merged commit e042805 into common-voice:main Feb 10, 2025
2 checks passed
@moz-dfeller
Copy link
Contributor

Hey @HarikalarKutusu thanks for your effort 🚀

@moz-dfeller moz-dfeller self-requested a review February 10, 2025 08:43
@HarikalarKutusu HarikalarKutusu deleted the fix-long-sentences-not-fitting branch February 21, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX-BUG/FR] Longer sentences do not fit into cards causing UX & recording problems
2 participants