Skip to content

Add Megrelian (xmf) variants and accents #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HarikalarKutusu
Copy link
Contributor

This PR is for @razmikb... It has been worked with local linguists.
For review by @ftyers

From this file:

image

@HarikalarKutusu HarikalarKutusu requested a review from a team as a code owner January 8, 2025 20:25
@HarikalarKutusu HarikalarKutusu requested review from moz-dfeller and removed request for a team January 8, 2025 20:25
@moz-dfeller
Copy link
Contributor

moz-dfeller commented Jan 9, 2025

Hey @HarikalarKutusu , I see that 'Zugdid' was spelled in two different ways, in the variant it's xmf-zugdid and in the accents it's zugid. Is that correct or possibly a typo?

@razmikb
Copy link
Contributor

razmikb commented Jan 9, 2025

Hi @moz-dfeller , it's intentional to distinguish the two. Zugdid refers to the dialect and Zugid to the subdialect. Zugdiduri/ Zugiduri are names both for the dialect and the sub-dialect. To prevent confusion on the code level, we decided to use the naming given in the tables.

@moz-dfeller
Copy link
Contributor

Thank you very much for the clarification @razmikb ! It's good to go from my side 👍

@razmikb
Copy link
Contributor

razmikb commented Jan 14, 2025

Hi @moz-dfeller, any news on when will this be live?

@moz-dfeller moz-dfeller merged commit 756b927 into common-voice:main Jan 14, 2025
@moz-dfeller
Copy link
Contributor

It's live @razmikb :)

@HarikalarKutusu HarikalarKutusu deleted the feat-add-megrelian-variants-accents branch February 21, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants